Fix rpmsgfs/rpmsgfs_client.c:774:3: warning: 'strcpy' writing 1 or more bytes into a region of size 0 overflows the destination #5823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re bytes into a region of size 0 overflows the destination Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
| @@ -740,8 +741,8 @@ int rpmsgfs_client_rename(FAR void *handle, FAR const char *oldpath, | |||
|
|
|||
| DEBUGASSERT(len <= space); | |||
There was a problem hiding this comment.
When DEBUGASSERT is a no-op, this check for buffer overflow will not exist.
I suggest:
if (len > space)
{
return -ENOMEM;
}
provided space is number of bytes we can actually use. If require one more byte, use >= instead:
if (len >= space)
{
return -ENOMEM;
}
There was a problem hiding this comment.
There isn't rpmsg_free_tx_payload_buffer api yet:
OpenAMP/open-amp#361
That is why DEBUGASSERT is added here since we can't return the buffer to pool without sending.
There was a problem hiding this comment.
Once OpenAMP/open-amp#361 get fixed, we can convert all DEBUGASSERT to if/else.
pkarashchenko
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found by change #5476.
Impact
Minor, fix warning
Testing
Pass CI